Enable betterMatchTypeExtractors in >= 3.6 #21198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
baseVersion is already 3.6.0 so I think we can just make the feature non-experimental now |
smarter
approved these changes
Jul 15, 2024
hamzaremmal
requested changes
Jul 16, 2024
smarter
changed the title
Gedochao
added
the
needs-minor-release
Done ✅ |
mbovel
force-pushed
the
mb/20538
branch
2 times, most recently
from
c1033c1 to
78fe701
Compare
hamzaremmal
requested changes
Aug 12, 2024
hamzaremmal
approved these changes
Aug 20, 2024
|
Wait, should it really be merged now? I thought we should wait for a minor release. |
|
We are on a minor release cycle, we are currently working on 3.6.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20538.