Skip to content

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jul 19, 2024
Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gedochao
Copy link
Contributor

BTW we'll likely want it backported to 3.5.1 because of VirtusLab/scala-cli#3029

Copy link
Contributor

@WojciechMazur WojciechMazur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

else
SCALA_CLI_CMD_BASH=("\"$PROG_HOME/bin/scala-cli\"")
fi
SCALA_CLI_CMD_BASH=("\"$PROG_HOME/bin/scala-cli\"")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder do we really need this cli-common-platform files anymore. There seems to be exactly 1 usage for each of them

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamzaremmal
Copy link
Member Author

I will wait for @bishabosha's review before merging this. unless we have some time constraints for backporting (@WojciechMazur ?)

@WojciechMazur
Copy link
Contributor

I will wait for @bishabosha's review before merging this. unless we have some time constraints for backporting (@WojciechMazur ?)

There won't be a 3.5.1-RC2 before 3.5.0 is published, so don't worry about the backports

@bishabosha bishabosha merged commit 0e93a38 into scala:main Jul 23, 2024
28 checks passed
@hamzaremmal hamzaremmal deleted the bump-scala-cli branch July 23, 2024 10:18
@WojciechMazur WojciechMazur added this to the 3.5.1 milestone Aug 12, 2024
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Aug 12, 2024
WojciechMazur added a commit that referenced this pull request Aug 13, 2024
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:done This PR was successfully backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants