Refine the bounds of the Tuple.Filter type lambda predicate ..
#21286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneFlesselle
force-pushed
the
tuples/filter
branch
from
455058c to
034207b
Compare
to only require it be defined on the elements of the tuple. This is one of the ongoing proposed tuple improvements, addressing scala#19175. As carefully pointed out by @sjrd, this _is_ a potential breaking change. See tests/neg/tuple-filter-compat.scala for an example. This is not an unprecedented change however, the analogous improvements were made to `Tuple.{Map, FlatMap}` in 28a695e.
EugeneFlesselle
force-pushed
the
tuples/filter
branch
from
034207b to
2ad5ba5
Compare
sjrd
approved these changes
Nov 11, 2024
WojciechMazur
added
the
backport:nominated
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to only require it be defined on the elements of the tuple.
This is one of the ongoing proposed tuple improvements, addressing #19175.
As carefully pointed out by @sjrd, this is a potential breaking change.
See tests/neg/tuple-filter-compat.scala for an example.
This is not an unprecedented change however, the analogous improvements were made to
Tuple.{Map, FlatMap}in 28a695e.I guess this should be discussed, and decided whether or not to merge, by the core team.