Skip to content

Only replace *new* errors by warnings under -migration #21289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Only replace *new* errors by warnings under -migration #21289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/report.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ object report:

def errorOrMigrationWarning(msg: Message, pos: SrcPos, migrationVersion: MigrationVersion)(using Context): Unit =
if sourceVersion.isAtLeast(migrationVersion.errorFrom) then
if !sourceVersion.isMigrating then error(msg, pos)
if sourceVersion != migrationVersion.errorFrom.prevMigrating then error(msg, pos)
else if ctx.settings.rewrite.value.isEmpty then migrationWarning(msg, pos)
else if sourceVersion.isAtLeast(migrationVersion.warnFrom) then warning(msg, pos)

Expand Down
5 changes: 5 additions & 0 deletions tests/neg/migrate-once.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
//> using options -source:3.5-migration

object Test:
for Some(x) <- Seq(Option(1)) yield x // error
// was warn before changes, but should warn only until 3.4-migration
Loading