Fixes IllegalAccessError with Java package protected class #21362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of Scala 2.x scala/scala 6023 Fixes 13841 Fixes 13897 **Problem** When compiling `builder.call1().call2()` where both are Java-defined package-protected class through a public subsclass, Scala 3 does not properly cast the receiver to the public class, and results in an IllegalAccessError. **Solution** This backports the casting fix from the Scala 2.x compiler.
This was referenced Aug 10, 2024
lrytz
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
LGTM
I was recently in the area (in Scala 2) for scala/scala#10794.
Though I wrote in the corresponding ticket (scala/bug#13007) "Scala 3 rejects the above example", this doesn't seem to be the case now. I'll create a new scala3 ticket for that.
Actually the Scala 3 behavior for the example I tried is is correct, so maybe there's nothing to do for Scala 3. |
This was referenced Sep 16, 2024
Closed
This was referenced Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of Scala 2.x scala/scala#6023 by @lrytz
Fixes #13841
Fixes #13897
Problem
When compiling
builder.call1().call2()where both are Java-defined package-protected class through a public subsclass, Scala 3 does not properly cast the receiver to the public class, and results in an IllegalAccessError.Solution
This backports the casting fix from the Scala 2.x compiler.