Re-use attachment in exportForwarders to handle ambiguous overloads #21518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjoel
commented
Aug 30, 2024
| addForwarders(selectors, Nil) | ||
| val forwarders = avoidClashes(buf.toList) | ||
| exp.pushAttachment(ExportForwarders, forwarders) | ||
| exp.putAttachment(ExportForwarders, forwarders) |
There was a problem hiding this comment.
On the other hand, it doesn't (at a glance) seem like this will ever give a different result, so maybe this is better?
exp.getAttachment(ExportForwarders).getOrElse:
addForwarders(selectors, Nil)
val forwarders = avoidClashes(buf.toList)
exp.putAttachment(ExportForwarders, forwarders)
forwarders
There was a problem hiding this comment.
Yes, let's try that alternative. It seems better.
exportForwarders can be called more than once for the same expression if there are ambiguous overloads. Just return the already computed ExportForwarders if that happens. Closes scala#21071
wjoel
changed the title
sjrd
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
exportForwarders can be called more than once for the same expression if there are ambiguous overloads.
Closes #21071