Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop scala3-presentation-compiler-non-bootstrapped #21708

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

hamzaremmal
Copy link
Member

Drop the non bootstrapped version of the presentation compiler and only keep a single one that uses the bootstrapped compiler and library

[test_non_bootstrapped]

@hamzaremmal hamzaremmal force-pushed the pc-only-bootstrapped branch from 995cb42 to 31b9249 Compare October 5, 2024 13:43
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with it, if the others agree.

Copy link
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So bootstrapped version would be the one that is actually released right? Just to make sure, I don't think I've actually seen in writing what is the difference between the two.

@rochala
Copy link
Contributor

rochala commented Oct 7, 2024

We've always released only bootstrapped artifacts. As far as I remember, it was added to provide better support for Scala doc module, which builds on non-bootstrapped compiler. We haven't really made any steps to build that support further

@tgodzik
Copy link
Contributor

tgodzik commented Oct 7, 2024

We've always released only bootstrapped artifacts. As far as I remember, it was added to provide better support for Scala doc module, which builds on non-bootstrapped compiler. We haven't really made any steps to build that support further

ach right, Metals will not support anything that only uses non-bootstrapped then. I so I guess the decision is in the compiler team whether it's ok.

@hamzaremmal hamzaremmal merged commit d2b418c into scala:main Oct 7, 2024
28 checks passed
@hamzaremmal hamzaremmal deleted the pc-only-bootstrapped branch October 7, 2024 09:35
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants