Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize named tuples #21710

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Finalize named tuples #21710

merged 4 commits into from
Oct 10, 2024
+22 −30

Conversation

EugeneFlesselle
Copy link
Contributor

Extracted from #21680 (review)

@EugeneFlesselle EugeneFlesselle mentioned this pull request Oct 5, 2024
Merged
@WojciechMazur
Copy link
Contributor

What's the status of these changes? Should it be included in 3.6.0?
It modifies the signatures of public methods so it should. How can we help to merge these changes?

@WojciechMazur WojciechMazur mentioned this pull request Oct 9, 2024
Closed
@EugeneFlesselle
Add an explicit type instantiation in NamedTuple.map
bd88a0f 
To avoid triggering a deep subtype comparison
needed for the inference of the higher-kinded type parameter.
odersky
odersky approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@odersky odersky merged commit 46f4860 into scala:main Oct 10, 2024
28 checks passed
@odersky odersky deleted the finalize-namedtuples-2 branch October 10, 2024 17:45
@odersky
Copy link
Contributor

odersky commented Oct 10, 2024

OK, merged now.

@WojciechMazur WojciechMazur mentioned this pull request Oct 15, 2024
Merged
@WojciechMazur WojciechMazur added this to the 3.6.0 milestone Oct 15, 2024
@WojciechMazur WojciechMazur added the backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" label Oct 15, 2024
WojciechMazur added a commit that referenced this pull request Oct 15, 2024
@WojciechMazur @EugeneFlesselle
Backport "Finalize named tuples" to 3.6.0 (#21773)
83ba0de 
Backports #21710 to 3.6.0-RC1

---------

Co-authored-by: Eugene Flesselle <eugene@flesselle.net>
@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odersky odersky odersky approved these changes

Assignees
No one assigned
Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EugeneFlesselle @WojciechMazur @odersky