Deterministically randomises test compilation order #2193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
reviewed
Apr 5, 2017
| val files = { | ||
| // Deterministically randomises compilation order | ||
| Random.setSeed(seed) | ||
| Random.shuffle(flatten(sourceDir).toList).toArray |
There was a problem hiding this comment.
Some other thread could mess with the global instance of Random. You should use a new instance of Random in here.
The previous implementation would compile tests in different orders from machine to machine, depending on the order in which *.scala files are listed by the operating system.
OlivierBlanvillain
force-pushed
the
deterministic-tests
branch
from
fbac9c1 to
f693ba7
Compare
OlivierBlanvillain
force-pushed
the
deterministic-tests
branch
from
bf6f33f to
8a83bb1
Compare
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation would compile tests in different orders from machine to machine, depending on the order in which *.scala files are listed by the operating system.