Fix #20471: owners of top-level symbols in cached quoted code being incorrect #21945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
approved these changes
Nov 18, 2024
hamzaremmal
reviewed
Nov 18, 2024
Comment on lines
+244
to
+246
| val treeCpy = TreeTypeMap(oldOwners = List(owner), newOwners = List(owner)).apply(tree) | ||
| // Then replace the symbol owner with the one pointed by the quote context. | ||
| treeCpy.changeNonLocalOwners(ctx.owner) |
There was a problem hiding this comment.
I was curious why not propose this change, I've tried it locally with the test for #20471 but the following test (and only one) tests/run-staging/quote-ackermann-1.scala fails.
Suggested change
| val treeCpy = TreeTypeMap(oldOwners = List(owner), newOwners = List(owner)).apply(tree) | |
| // Then replace the symbol owner with the one pointed by the quote context. | |
| treeCpy.changeNonLocalOwners(ctx.owner) | |
| TreeTypeMap(oldOwners = List(owner), newOwners = List(ctx.owner)).apply(tree) | |
| // Then replace the symbol owner with the one pointed by the quote context. | |
| //treeCpy.changeNonLocalOwners(ctx.owner) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20471
I would just reopen #21932, but it looks like that's disallowed after force pushing... (apologies for the spam)