Drop phase.isTyper use in isLegalPrefix/asf #21954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that "asSeenFrom" (aka asf) is used by SymDenotation#findMember,
which is used by TypeComparer's "hasMatchingMember", as a part of
"compareRefinedSlow".
Previously (using the minimisation in i17222.8.scala) `summonOne` is
inlined during the "inlining" phase, while "summonInline" is inlined
during typing. The result is that during inlining we fail to find
`Reader[BC, Int]` because we incorrectly consider `A{type F = Int}` as
stable.
Gedochao
added
the
backport:nominated
Gedochao
requested review from
noti0na1 and
sjrd
and removed request for
jchyb
noti0na1
reviewed
Nov 20, 2024
dwijnand
deleted the
i17222-anon-mixin-inline-match-erasedValue-summonInline
branch
WojciechMazur
removed
the
backport:nominated
This was referenced Feb 24, 2025
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 26, 2025
The body of this method used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in scala#21954 (originally included in
3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a
number of regressions, the last ones discussed in scala#23423.
To make the testcases added in scala#21594 pass, this PR proposes a less drastic
change: relax isLegalPrefix as before, unless we're doing an implicit search.
This should dramatically reduce the possibility for regressions.
smarter
added a commit
to dotty-staging/dotty
that referenced
this pull request
Jun 26, 2025
The body of isLegalPrefix used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in scala#21954 (originally included in
3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a
number of regressions, the last ones discussed in scala#23423.
To make the testcases added in scala#21594 pass, this PR proposes a less drastic
change: relax isLegalPrefix as before, unless we're doing an implicit search.
This should dramatically reduce the possibility for regressions.
Fixes scala#23423.
Fixes scala#22676.
smarter
added a commit
that referenced
this pull request
Jun 27, 2025
The body of isLegalPrefix used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in #21954 (originally
included in 3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This
has led to a number of regressions, the last ones discussed in #23423.
To make the testcases added in #21594 pass, this PR proposes a less
drastic change: relax isLegalPrefix as before, unless we're doing an
implicit search. This should dramatically reduce the possibility for
regressions.
Fixes #23423.
Fixes #22676.
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Jun 30, 2025
The body of isLegalPrefix used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in scala#21954 (originally included in
3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a
number of regressions, the last ones discussed in scala#23423.
To make the testcases added in scala#21594 pass, this PR proposes a less drastic
change: relax isLegalPrefix as before, unless we're doing an implicit search.
This should dramatically reduce the possibility for regressions.
Fixes scala#23423.
Fixes scala#22676.
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Jun 30, 2025
The body of isLegalPrefix used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in scala#21954 (originally included in
3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a
number of regressions, the last ones discussed in scala#23423.
To make the testcases added in scala#21594 pass, this PR proposes a less drastic
change: relax isLegalPrefix as before, unless we're doing an implicit search.
This should dramatically reduce the possibility for regressions.
Fixes scala#23423.
Fixes scala#22676.
[Cherry-picked 2e4bc0a][modified]
WojciechMazur
pushed a commit
that referenced
this pull request
Jul 16, 2025
The body of isLegalPrefix used to read:
pre.isStable || !ctx.phase.isTyper
but was changed to drop the second condition in #21954 (originally included in
3.6.4-RC1, reverted from 3.6.4 final but back in 3.7). This has led to a
number of regressions, the last ones discussed in #23423.
To make the testcases added in #21594 pass, this PR proposes a less drastic
change: relax isLegalPrefix as before, unless we're doing an implicit search.
This should dramatically reduce the possibility for regressions.
Fixes #23423.
Fixes #22676.
[Cherry-picked 2e4bc0a]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that "asSeenFrom" (aka asf) is used by SymDenotation#findMember,
which is used by TypeComparer's "hasMatchingMember", as a part of
"compareRefinedSlow".
Previously (using the minimisation in i17222.8.scala)
summonOneisinlined during the "inlining" phase, while "summonInline" is inlined
during typing. The result is that during inlining we fail to find
Reader[BC, Int]because we incorrectly considerA{type F = Int}asstable.
Fixes #17222