Handle old given syntax where identifier and type are seperated by new line #21957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
reviewed
Nov 17, 2024
| @@ -1010,13 +1010,25 @@ object Parsers { | |||
| skipParams() | |||
| lookahead.isColon | |||
| && { | |||
| lookahead.nextToken() | |||
There was a problem hiding this comment.
I would move the lookahead.nextToken() to line 1018, just before
!lookahead.isAfterLineEnd. That saves us a useless nextToken when source is 3.6.
WojciechMazur
added
the
backport:nominated
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
KacperFKorban
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 20, 2024
…w line (scala#21957) Fixes scala#21768 Fixes usages of `with {...}` and `= new {}` declarations presented in tests.
KacperFKorban
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
Nov 29, 2024
…w line (scala#21957) Fixes scala#21768 Fixes usages of `with {...}` and `= new {}` declarations presented in tests.
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Feb 19, 2025
…w line (scala#21957) Fixes scala#21768 Fixes usages of `with {...}` and `= new {}` declarations presented in tests.
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Feb 19, 2025
…w line (scala#21957) Fixes scala#21768 Fixes usages of `with {...}` and `= new {}` declarations presented in tests. [Cherry-picked 7644ecd][modified]
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Feb 19, 2025
…w line (scala#21957) Fixes scala#21768 Fixes usages of `with {...}` and `= new {}` declarations presented in tests. [Cherry-picked 7644ecd][modified]
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Mar 6, 2025
…w line (scala#21957) Fixes scala#21768 Fixes usages of `with {...}` and `= new {}` declarations presented in tests.
tgodzik
added a commit
to scala/scala3-lts
that referenced
this pull request
Mar 6, 2025
…w line (scala#21957) Fixes scala#21768 Fixes usages of `with {...}` and `= new {}` declarations presented in tests. [Cherry-picked 7644ecd][modified]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21768
Fixes usages of
with {...}and= new {}declarations presented in tests.