Consider all arguments in Annotations.refersToParamOf

[mbovel]

We should also include type arguments in Annotations.refersToParamOf.

[smarter]

LGTM, but I pointed out another missing case in a comment.

[smarter]

When I was playing with annotations and macros, I also noticed that this check was not enough: when we write down in source code a singleton type x.type, it will be parsed as SingletonTypeTree(Ident(x)), but in a macro we usually create a reference to x.type with just a TermRef, so no Ident tree node will be involved.

[mbovel]

I actually started by writing this:

    def refersToParamOf(tl: TermLambda)(using Context): Boolean =
      tree.existsSubTree:
        _.tpe.existsPart:
          _.stripped match
            case TermParamRef(tl1, _) => tl eq tl1
            case _ => false

But couldn't come up with test-cases where that was necessary.

I didn't think of macros.

I guess we'd need something like the above if we want to handle user-generated types that don't have corresponding trees.

[mbovel]

When generated from a macro, wouldn't the generated type always be encapsulated in a TypeTree?

Maybe something like that would be sufficient?

    def refersToParamOf(tl: TermLambda)(using Context): Boolean =
      def referToParam(tp: Type) =
        tp.stripped match
          case TermParamRef(tl1, _) => tl eq tl1
          case _ => false
      val args = tpd.allArguments(tree)
      if args.isEmpty then false
      else tree.existsSubTree:
        case id: (Ident | This) => referToParam(id.tpe)
        case tpt: TypeTree => tpt.tpe.existsPart(referToParam)
        case _ => false

[mbovel]

Thanks a lot for the quick and pertinent review!

Let's already merge the arguments fix.

I created an issue for the param refs search issue: #22008.