fix: Only fallback to the definition of a synthetic valdef if it is zero extent #22551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
approved these changes
Feb 11, 2025
…ero extent Co-Authored-By: Katarzyna Marek <26606662+kasiaMarek@users.noreply.github.com>
KacperFKorban
force-pushed
the
fix-metals-i7038
branch
from
520805a to
db0f4bf
Compare
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Apr 22, 2025
…ero extent (scala#22551) closes scalameta/metals#7038 closes scalameta/metals#7191 fixes the reproduction issue from scala#22217 Co-authored-by: Katarzyna Marek <26606662+kasiaMarek@users.noreply.github.com> [Cherry-picked 37206cc]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes scalameta/metals#7038
closes scalameta/metals#7191
fixes the reproduction issue from #22217