Better LSP completions inside of backticks #22555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the presentation compiler name completions inside of backticks. The existing gaps which motivate doing this are outlined in [this Metals feature request][0]. [0]: scalameta/metals-feature-requests#418
harpocrates
added a commit
to harpocrates/metals
that referenced
this pull request
Feb 10, 2025
Scala 2 only - the [corresponding Scala 3 change][0] has already been merged. Completions can now be triggered from inside of backticks. In addition, the backtick itself is added as a completion character. Especially when the editor is configured to auto-close backticks, this plays nicely with completions now producing useful results inside of backticks. Closes [this feature request][1] [0]: scala/scala3#22555 [1]: scalameta/metals-feature-requests#418
harpocrates
added a commit
to harpocrates/metals
that referenced
this pull request
Feb 10, 2025
Scala 2 only - the [corresponding Scala 3 change][0] has already been merged. Completions can now be triggered from inside of backticks. In addition, the backtick itself is added as a completion character. Especially when the editor is configured to auto-close backticks, this plays nicely with completions now producing useful results inside of backticks. Closes [this feature request][1] [0]: scala/scala3#22555 [1]: scalameta/metals-feature-requests#418
harpocrates
added a commit
to harpocrates/metals
that referenced
this pull request
Feb 10, 2025
Scala 2 only - the [corresponding Scala 3 change][0] has already been merged. Completions can now be triggered from inside of backticks. In addition, the backtick itself is added as a completion character. Especially when the editor is configured to auto-close backticks, this plays nicely with completions now producing useful results inside of backticks. Closes [this feature request][1] [0]: scala/scala3#22555 [1]: scalameta/metals-feature-requests#418
harpocrates
added a commit
to harpocrates/metals
that referenced
this pull request
Feb 10, 2025
Scala 2 only - the [corresponding Scala 3 change][0] has already been merged. Completions can now be triggered from inside of backticks. In addition, the backtick itself is added as a completion character. Especially when the editor is configured to auto-close backticks, this plays nicely with completions now producing useful results inside of backticks. Closes [this feature request][1] [0]: scala/scala3#22555 [1]: scalameta/metals-feature-requests#418
tgodzik
pushed a commit
to scalameta/metals
that referenced
this pull request
Feb 11, 2025
Scala 2 only - the [corresponding Scala 3 change][0] has already been merged. Completions can now be triggered from inside of backticks. In addition, the backtick itself is added as a completion character. Especially when the editor is configured to auto-close backticks, this plays nicely with completions now producing useful results inside of backticks. Closes [this feature request][1] [0]: scala/scala3#22555 [1]: scalameta/metals-feature-requests#418
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the presentation compiler name completions inside of backticks. The existing gaps which motivate doing this are outlined in this Metals feature request.