Approximate annotated types in wildApprox
#22893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
approved these changes
Apr 1, 2025
|
Thanks a lot for the quick review! Comment added! |
This was referenced Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22874.
wildApproxapproximates parameter references and type variables by wildcards. When doing so for anAnnotatedType, this can produce trees with wildcards types, causing the type assigner to fail. For example, considerApply(fn, args)wherefnhas typeTermParamRef. ApplyingwildApproxwill approximate the type offnto a wildcard, leading the type assigner forApplyto emit an error stating that<?>does not take parameters.This issue is somehow similar to the one described in #19957 (comment), which was fixed by #21941 (and re-worked in #22839).
This PR fixes the issue by approximating annotated types in
wildApprox: annotated types are approximated by their parent types if they are not refining, or by wildcards upper-bounded by their parent types if they are.