Improve checking LHS of Assign #22977
Merged
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/22970-var-import
branch
from
d38c344 to
48e3493
Compare
som-snytt
force-pushed
the
issue/22970-var-import
branch
from
48e3493 to
05cd547
Compare
|
Could rebase on main? There seems to be some conflicts. |
som-snytt
force-pushed
the
issue/22970-var-import
branch
from
05cd547 to
e7d18a7
Compare
I think it's time for that coffee. Edit: by which I mean, I still have reservations about this simple solution, but I will follow up with an over-engineered solution at a future date. |
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
May 12, 2025
Fixes scala#22970 Simple example showing how awkward this is compared to a traversal, where there is more control when descending. Previously, it "ignored" the LHS of Assign to avoid taking `x = y` as ref to `x` instead of assignment to. Now, "mark" the LHS as assignment, so `transformIdent` and `Select` set a "mode" flag, such that `x` is correctly taken as either a ref or assign to `x`. Probably there is more complex syntax to handle as LHS, but I haven't had coffee yet. [Cherry-picked 9bee756]
odersky
pushed a commit
to dotty-staging/dotty
that referenced
this pull request
May 12, 2025
Fixes scala#22970 Simple example showing how awkward this is compared to a traversal, where there is more control when descending. Previously, it "ignored" the LHS of Assign to avoid taking `x = y` as ref to `x` instead of assignment to. Now, "mark" the LHS as assignment, so `transformIdent` and `Select` set a "mode" flag, such that `x` is correctly taken as either a ref or assign to `x`. Probably there is more complex syntax to handle as LHS, but I haven't had coffee yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22970
Simple example showing how awkward this is compared to a traversal, where there is more control when descending.
Previously, it "ignored" the LHS of Assign to avoid taking
x = yas ref toxinstead of assignment to.Now, "mark" the LHS as assignment, so
transformIdentandSelectset a "mode" flag, such thatxis correctly taken as either a ref or assign tox.Probably there is more complex syntax to handle as LHS, but I haven't had coffee yet.