improvement: Don't dealias named tuples for type hints #23013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes the code to grow quite a lot. Fixes scalameta/metals#7397
|
is there a good reason to not try and simplify the result of match types? in the linked issue its unreduced |
The only reason is that I don't know how to do it :D |
tgodzik
force-pushed
the
fix-named-tuples
branch
from
f866a7b to
f7d13ee
Compare
Also make it work on hover, completions and inferred type
tgodzik
force-pushed
the
fix-named-tuples
branch
from
f7d13ee to
ae219e5
Compare
|
Ok, it seems we managed to get the named tuples to simplify nicely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes the code to grow quite a lot.
Fixes scalameta/metals#7397