chore: filter allowed source versions by import and by settings #23215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamzaremmal
commented
May 21, 2025
| @@ -8,7 +8,8 @@ import Feature.isPreviewEnabled | |||
| import util.Property | |||
|
|
|||
| enum SourceVersion: | |||
| case `3.0-migration`, `3.0`, `3.1` // Note: do not add `3.1-migration` here, 3.1 is the same language as 3.0. | |||
| case `3.0-migration`, `3.0` | |||
| case `3.1-migration`, `3.1` | |||
There was a problem hiding this comment.
We need to add this object so that we can refer to it when making illegal. It is also added for consistency
WojciechMazur
approved these changes
May 21, 2025
hamzaremmal
added
the
backport:nominated
WojciechMazur
added
backport:accepted
WojciechMazur
added
backport:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23214
We also split the logic to handle illegal imports separately as in #23082, we want to authorise
2.13in imports but not in the settings