Take inferred or explicit refinement result for unused check #23325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the check considered an explicit refinement to "nowarn" the corresponding member of an anonymous class.
Since an anonymous
Selectablewill infer a refinement type, use the type for the relaxed warning.Arguably, it would still be useful to warn for the
scala.Selectablecase, where it may be thatselectDynamicis the preferred interface, but that is not done here. As with other anonymous classes, an explicit type can be used instead (to request a warning forSelectableor silence a warning for other classes).Fixes #23323