Port Inlay hints for name parameters #23375
Open
+228
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zielinsky
force-pushed
the
name-parameters
branch
2 times, most recently
from
971cee4 to
d41d2a3
Compare
zielinsky
force-pushed
the
name-parameters
branch
from
d41d2a3 to
5e5a48c
Compare
tgodzik
requested changes
Jun 20, 2025
| @@ -611,17 +611,17 @@ class InlayHintsSuite extends BaseInlayHintsSuite { | |||
| |class DemoSpec { | |||
| | import ScalatestMock._ | |||
| | | |||
| | /*StringTestOps<<(6:17)>>(*/"foo"/*)*/ should {/*=> */ | |||
There was a problem hiding this comment.
These are byName parameters being tested here, we should probably not change this test case, no?
| @@ -29,6 +30,7 @@ import dotty.tools.dotc.util.Spans.Span | |||
| import org.eclipse.lsp4j.InlayHint | |||
| import org.eclipse.lsp4j.InlayHintKind | |||
| import org.eclipse.{lsp4j as l} | |||
| import dotty.tools.dotc.core.NameOps.fieldName | |||
There was a problem hiding this comment.
Suggested change
| import dotty.tools.dotc.core.NameOps.fieldName | |
| import dotty.tools.dotc.core.NameOps.fieldName |
I would try and keep the imports sorted
| adjusted | ||
| None | ||
|
|
||
| def adjustParameterPos(pos: SourcePosition): SourcePosition = |
There was a problem hiding this comment.
Why do we need this function? Isn't it basically the same what we had above? For None we return adjusted which is adjustPos(pos)
Or alternative just have one NamedParameters.unapply for both and only adjust showing => when the proper parameter is selected
| @@ -116,8 +118,8 @@ class PcInlayHintsProvider( | |||
| InlayHintKind.Type, | |||
| ) | |||
| .addDefinition(adjustedPos.start) | |||
| case ByNameParameters(byNameParams) => | |||
| def adjustByNameParameterPos(pos: SourcePosition): SourcePosition = | |||
| case NamedParameters(_) | ByNameParameters(_) => | |||
There was a problem hiding this comment.
We now invoke the unapply and don't do anything with the results, no? Could we split it into two cases and just extract common methods? Otherwise for each tree we calculate everything twice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add inlay hints for name parameters.
Porting scalameta/metals#7400