Improve quotes reflection reference documentation #23385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Jun 18, 2025
bishabosha
reviewed
Jun 18, 2025
bishabosha
reviewed
Jun 18, 2025
bishabosha
reviewed
Jun 18, 2025
bishabosha
reviewed
Jun 18, 2025
Co-authored-by: Jamie Thompson <bishbashboshjt@gmail.com>
bishabosha
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is enough, but the I would say most important overview (and most common pitfalls, from what I noticed in my experiences and from some submitted issues) are included.
It's tough to see in the raw .md file here, but in Scaladoc there is a hierarchy shown, which I think helps with the readability:
I think another improvement here could be done by specifying in https://scala-lang.org/api/3.3_LTS/scala/quoted/Quotes$reflectModule.html# which AST trees correspond to what code, but that's probably a little tricky to do cleanly