Skip to content

Allow implicit parameters in extractors #23500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Allow implicit parameters in extractors #23500

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/src/dotty/tools/dotc/typer/Applications.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1581,7 +1581,7 @@ trait Applications extends Compatibility {
val newAcc =
params match
case param :: _ if param.isType => true
case param :: _ if param.isTerm && !param.isOneOf(GivenOrImplicit) => false
case param :: _ if param.isTerm && !param.is(Given) => false
case _ => acc
hasTrailingTypeParams(paramss.tail, newAcc)

Expand Down
18 changes: 18 additions & 0 deletions tests/pos/i23499.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
def summonsTest =
given Type[String] = ???
val opt1: Option[Wrapper[String]] = Wrapper.unapply[String] // ok
val opt2 = Wrapper.unapply[String]
opt2.map(_.getValue)

def patternMatchTest =
Type[String] match
case Wrapper(v) => v.getValue // was an error

type Type[A] = Class[A] // any rhs would work here
object Type:
def apply[A]: Type[A] = ???

trait Wrapper[T]:
def getValue: T = ???
object Wrapper:
def unapply[T](implicit ev: Type[T]): Option[Wrapper[T]] = None
Loading