-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Encode path of class #23503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Encode path of class #23503
Conversation
4e7430f
to
31c5b75
Compare
(Temporarily?) exclude a test from best effort neg, where the test file has a hyphen. Under JDK 23, a bootstrap error at
must spin up a by-name for the There is also a long-running test in that group, also under JDK 23, but vulpix doesn't report test names (is there a verbose option?). The
```
at dotty.tools.dotc.core.MatchReducer.recur$2(TypeComparer.scala:3921)
at dotty.tools.dotc.core.MatchReducer.op$proxy90$1(TypeComparer.scala:3940)
at dotty.tools.dotc.core.MatchReducer.matchCases(TypeComparer.scala:3940)
at dotty.tools.dotc.core.Types$MatchType.reduced$$anonfun$1(Types.scala:5239)
at dotty.tools.dotc.core.Types$MatchType$$Lambda/0x00007102ef654f80.apply(Unknown Source)
at dotty.tools.dotc.core.TypeComparer.inSubComparer(TypeComparer.scala:3311)
at dotty.tools.dotc.core.TypeComparer.reduceMatchWith(TypeComparer.scala:3322)
at dotty.tools.dotc.core.TypeComparer$.reduceMatchWith(TypeComparer.scala:3533)
at dotty.tools.dotc.core.Types$MatchType.reduced(Types.scala:5239)
at dotty.tools.dotc.core.Types$Type.tryNormalize(Types.scala:1593)
at dotty.tools.dotc.core.Types$Type.normalized(Types.scala:1587)
at dotty.tools.dotc.core.Types$MatchType.reduced$$anonfun$1(Types.scala:5239)
at dotty.tools.dotc.core.Types$MatchType$$Lambda/0x00007102ef654f80.apply(Unknown Source)
at dotty.tools.dotc.core.TypeComparer.inSubComparer(TypeComparer.scala:3311)
at dotty.tools.dotc.core.TypeComparer.reduceMatchWith(TypeComparer.scala:3322)
at dotty.tools.dotc.core.TypeComparer$.reduceMatchWith(TypeComparer.scala:3533)
at dotty.tools.dotc.core.Types$MatchType.reduced(Types.scala:5239)
at dotty.tools.dotc.core.Types$Type.tryNormalize(Types.scala:1593)
at dotty.tools.dotc.core.Types$AppliedType.tryNormalize(Types.scala:4709)
at dotty.tools.dotc.core.TypeOps$.simplify(TypeOps.scala:152)
at dotty.tools.dotc.core.Types$Type.simplified(Types.scala:2101)
at dotty.tools.dotc.core.MatchReducer.recur$2(TypeComparer.scala:3921)
at dotty.tools.dotc.core.MatchReducer.op$proxy90$1(TypeComparer.scala:3940)
```
As a branding note, it would have been great if |
The JDK 23 failure is
I guess it is stack.
The test is an erroneous match type, so maybe it is related to the long-running test; for some reason it passes JDK 17 not 23. Exiting right away shows
They say don't try to recover from SOE but we don't believe them. Maybe there is a JVM-specific dimension, besides default stack size or whatever. |
If you propagate the SOE, you are SOL and vulpix hangs.
I didn't expect that. |
Fixes #22866
TastyFileUtil.getClassName
[sic] encodes its path result so thata.b
is not taken as two segments.