Skip to content

Switch TypeApplications to given extensions #23512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

som-snytt
Copy link
Contributor

Casual refactor to try newer features.

@som-snytt
Copy link
Contributor Author

I prefer to assume it's yet another spurious test failure.

[info] Test run dotty.tools.pc.tests.hover.HoverTermSuite started
[info] Test dotty.tools.pc.tests.hover.HoverTermSuite.for-keyword started
Error:  Test dotty.tools.pc.tests.hover.HoverTermSuite.for-keyword failed: java.util.concurrent.CancellationException: null, took 10.636 sec
Error:      at java.util.concurrent.CompletableFuture.cancel(CompletableFuture.java:2276)
Error:      at scala.meta.internal.pc.CompilerAccess.onCompilerJobQueue$$anonfun$3$$anonfun$1(CompilerAccess.scala:231)
Error:      at java.util.concurrent.FutureTask.run(FutureTask.java:266)
Error:      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
Error:      at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
Error:      at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
Error:      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
Error:      at java.lang.Thread.run(Thread.java:748)

There is an infrastructure problem with so many recent failures.

pc tests are inherently flaky if they are reactive. It would be nice to have tiers of unit tests, functional tests (integration), and liveliness tests that might time out but which would be run in a quiescent environment maybe once a day.

@som-snytt som-snytt marked this pull request as ready for review July 12, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant