Handle FlexibleTypes in asContextFunctionType #23865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the macro/quote version of the issue is reproducible in the test setup, but added nonetheless. |
|
Ah, OK, good point. |
hamzaremmal
reviewed
Sep 3, 2025
| case tp1 @ PolyFunctionOf(mt: MethodType) if mt.isContextualMethod => | ||
| tp1 | ||
| case tp1: FlexibleType => | ||
| asContextFunctionType(tp1.underlying) |
There was a problem hiding this comment.
Maybe I'm missing something here so I do have a question: Why do we drop the information that this was a Flexible Type (FT) instead of wrapping it over FT?
There was a problem hiding this comment.
For the purpose here, we only want to extract the information of a context function, so it's ok to widen a flexible type. I would prefer to strip any OrNull/flexible type at the beginning of this function.
There was a problem hiding this comment.
So do you mean changing
tp.stripTypeVar.dealias match
to
tp.stripTypeVar.dealias.stripNull match
at the beginning (instead of adding this case)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23845