Infer Local for val constructor params
#23871
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbovel
force-pushed
the
mb/22620
branch
4 times, most recently
from
b9d1a28 to
1db0b01
Compare
|
This PR results in cyclic reference errors in some community build projects. I am wondering if that is caused by reading the |
This was referenced Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another take on #22620, similar to #23378, but it prevents removing the
Localmodifiers from constructor parameters that are notvals. To achieve this, we introduce a new flag,NotAField, to record when a class parameter was not declared as aval.I tried using the existing
NonMemberflag instead of adding a new one, but that caused unintended side effects for value classes.