Fix "Regression in zio/zio-schema for typer/implicit resolution" #24156
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zielinsky
force-pushed
the
i24007_2
branch
2 times, most recently
from
ad2e4d3 to
376766b
Compare
odersky
reviewed
Oct 9, 2025
|
For what it worth taking the max size of the bounds was also my thinking when looking into #24007 |
odersky
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes implicit divergence checking regression by correcting how
TypeSizeAccumulatorhandlesTypeParamRefbounds. Instead of adding both upper and lower bounds to the type size, we now take the maximum of both bound sizes.Fixes #24007