Warn if reach capability in result will likely cause leakage #24860
+91
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
changed the title
An unboxed reach in a result type of a method will in almost all cases lead to use leakage error in the body of the method (except if the body is pure, and we widen to the reach without cause). Warn at this point already so that the leakage error that follows can be better understood.
odersky
force-pushed
the
add-reach-warning
branch
from
975b8a9 to
e5d56ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An unboxed reach in a result type of a method will in almost all cases lead to use leakage error in the body of the method (except if the body is pure, and we widen to the reach without cause). Warn at this point already so that the leakage error that follows can be better understood.