Add CanEqual instance for NamedTuple #24890
Open
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require same type for names. A possible other formulation could compare name types with `=:=` evidence, but this only benefits error messages with an explicit summon for CanEqual, and users would likely identify that the name fields dont match anyway.
bishabosha
force-pushed
the
named-tuples-strictEquality
branch
from
24bddc9 to
6d5eb16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Require same type for names. A possible other formulation could compare name types with
=:=evidence, but this only benefits error messages with an explicit summon for CanEqual, and users would likely identify that the name fields dont match anyway.