Drop -print-lines option #24905
Merged
Drop -print-lines option #24905
+71
−134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not seem to be used anywhere and it complicates text formatting considerably.
som-snytt
reviewed
Jan 5, 2026
tests/neg/i13026.scala
Outdated
| @@ -1,5 +1,3 @@ | |||
| //> using options -print-lines | |||
|
|
|||
| val x: Int = "not an int" // error | |||
Contributor
There was a problem hiding this comment.
Could just delete the file.
Maybe we should consult the print-lines community? Is there a meet-up in London for that?
Amazing simplification, of the YAGNI variety.
Contributor
Author
There was a problem hiding this comment.
Right, that test did nothing anyway.
som-snytt
approved these changes
Jan 6, 2026
Contributor
som-snytt
left a comment
som-snytt
left a comment
There was a problem hiding this comment.
This is a follow-up to #14227 (comment)
... what is -print-lines supposed to do? Can we remove it? 😅
It has no effect on scalac -decompile task. The commit history hints at the maintenance burden. I regret my earlier comment that YAGNI, because now it is FOMO: will I want to see line ranges in my rich dev env of 2026? But that sounds like a downstream tooling issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not seem to be used anywhere and it complicates text formatting considerably.