Skip to content

Conversation

@smarter
Copy link
Member

@smarter smarter commented Sep 17, 2017

I'm suspicious.

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@liufengyun
Copy link
Contributor

liufengyun commented Sep 17, 2017 via email

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 1 running.

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

I think the bot decided to run the benchmarks again because you quoted the command :).

@liufengyun
Copy link
Contributor

Thanks for the catch @smarter . The duplicate job removed and system updated. Now commands have to start from a line, so quoted commands are excluded.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3137 to see the changes.

Benchmarks is based on merge(s) with master

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

Looks like the benchmark changes made a big difference, invalidating the results of #3133 and #3136. @liufengyun I suggest reverting the changes for now. In the future I guess we'll need to rerun the benchmarks for all points when we make changes like this.

@liufengyun
Copy link
Contributor

@smarter I've temporarily reverted the changes in liufengyun/bench@19cd60c on the server, which affects 5 lines. Now you can try again.

Note that re-run all benchmarks is both computationally expensive and laborious, thus re-run is only justified when there's a compelling reason.

  1. Each point takes about 1 hour
  2. The dependencies/structure of the compiler is changing, which requires updating the infrastructure to fit the compiler every time it changes.

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

test performance please

@dottybot
Copy link
Member

performance test scheduled: 1 job(s) in queue, 0 running.

@dottybot
Copy link
Member

Performance test finished successfully:

Visit http://dotty-bench.epfl.ch/3137/ to see the changes.

Benchmarks is based on merge(s) with master

@smarter
Copy link
Member Author

smarter commented Sep 17, 2017

This looks more reasonable to me.

@smarter smarter closed this Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants