Add an error message class for phantom types #3399
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Oct 29, 2017
maseev
changed the title
|
That's interesting. For some reason a CI build failed on the clone phase 😟 |
|
Phantom types are most likely going to be removed from Dotty, being replaced by the "unused" PR #3342. So it's not a good time to improve error messages for them. |
|
Wow, I didn't know that. If I'm not mistaken there are still a bunch of places in this issue related to the Phantom types. Maybe it would be a good idea to remove them from the list? Should I close this PR for now? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to #1589. Specifically, it adds a new error message class for the following case
Typer.scala:1427(ctx.error("only static objects can extend scala.Phantom", cdef.pos))