Named type error messages to new format #3419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottybot
reviewed
Nov 1, 2017
allanrenucci
suggested changes
Nov 1, 2017
| case class UndefinedNamedTypeArgument(undefinedName: Name, definedNames: List[Name])(implicit ctx: Context) | ||
| extends Message(UndefinedNamedTypeArgumentID) { | ||
| val kind = "Syntax" | ||
| val msg = hl"Type parameter $undefinedName is undefined. Expected one of ${definedNames.mkString(", ")}." |
There was a problem hiding this comment.
definedNames.map(_.show).mkString(", ")
| assertEquals("C", n1.show) | ||
| assertEquals("A"::"B"::Nil, l1.map(_.show)) | ||
| assertEquals("C", n2.show) | ||
| assertEquals("A"::"B"::Nil, l2.map(_.show)) |
There was a problem hiding this comment.
val tpParams = List("A", "B")
assertEquals(tpParams, l1.map(_.show))
assertEquals(tpParams, l2.map(_.show))| @@ -1865,4 +1865,18 @@ object messages { | |||
| |Excluded from this rule are methods that are defined in Java or that override methods defined in Java.""" | |||
| } | |||
| } | |||
|
|
|||
| case class DuplicateNamedTypeArgument(name: Name)(implicit ctx: Context) | |||
There was a problem hiding this comment.
Rename to DuplicateNamedTypeParameter
| val explanation = "" | ||
| } | ||
|
|
||
| case class UndefinedNamedTypeArgument(undefinedName: Name, definedNames: List[Name])(implicit ctx: Context) |
There was a problem hiding this comment.
Rename to UndefinedNamedTypeParameter
| MissingEmptyArgumentListID | ||
| MissingEmptyArgumentListID, | ||
| DuplicateNamedTypeArgumentID, | ||
| UndefinedNamedTypeArgumentID |
There was a problem hiding this comment.
Rename DuplicateNamedTypeParameterID and UndefinedNamedTypeParameterID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1589.
Changes error messages for named type parameters to use new format (with tests).