Skip to content

Use new NotAMember new error format in PostTyper #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2017

Conversation

DSouzaM
Copy link
Contributor

@DSouzaM DSouzaM commented Nov 1, 2017

Small fix. I started implementing a new class before I realized one existed already 😃

Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

@DSouzaM
Copy link
Contributor Author

DSouzaM commented Nov 1, 2017

A test is failing because actual output:

scala> import util.foo
1 | import util.foo
  |             ^^^
  |           value `foo` is not a member of util - did you mean `util.Left`?

doesn't match expected output:

scala> import util.foo
1 | import util.foo
  |             ^^^
  |             foo is not a member of util

as a result of the change (these errors are caught by PostTyper).

Meanwhile, both actual and expected match for the following case, which is caught by TypeAssigner:

scala> import util.foo.bar
1 | import util.foo.bar
  |        ^^^^^^^^
  |        value `foo` is not a member of util - did you mean `util.Left`?

Is there a distinction between these two errors that causes them to be handled differently? Should they continue to have different error messages?

@allanrenucci
Copy link
Contributor

You can update the expected output of the test case

Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@allanrenucci allanrenucci merged commit a549dd1 into scala:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants