Fix #347 implicitScope for the case when implicit scopes cannot be cached #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes scala#347. When Config.cacheImplicitScopes == false or an implicit scope is requested for a type for which it cannot be cached, this change causes the same computation to be applied as if the scope were looked up in the implicit scope cache and not found.
olhotak
force-pushed
the
fix-cacheiscope
branch
from
b9231e0 to
5409448
Compare
|
Rebased to current master. |
odersky
added a commit
that referenced
this pull request
Feb 7, 2015
Fix #347 implicitScope for the case when implicit scopes cannot be cached
tgodzik
added a commit
to tgodzik/scala3
that referenced
this pull request
Apr 29, 2025
Backport "pc: Properly adjust indentation when inlining blocks" to 3.3 LTS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #345.
This fixes #347.
When
Config.cacheImplicitScopes == falseor an implicit scope isrequested for a type for which it cannot be cached, this change
causes the same computation to be applied as if the scope were
looked up in the implicit scope cache and not found.