Fix #4060 by marking ghost symbols as unstable #4071
Conversation
| @@ -600,7 +600,7 @@ object SymDenotations { | |||
|
|
|||
| /** Is this a denotation of a stable term (or an arbitrary type)? */ | |||
| final def isStable(implicit ctx: Context) = | |||
| isType || is(Stable) || !(is(UnstableValue) || info.isInstanceOf[ExprType]) | |||
| !is(Ghost) && (isType || is(Stable) || !(is(UnstableValue) || info.isInstanceOf[ExprType])) | |||
There was a problem hiding this comment.
Testing is(Ghost) first is probably overkill, I'll try isType || !is(Ghost) && (is(Stable) || !(is(UnstableValue) || info.isInstanceOf[ExprType])) after the build finishes.
|
test performance please |
|
performance test scheduled: 1 job(s) in queue, 0 running. |
|
Performance test finished successfully: Visit http://dotty-bench.epfl.ch/4071/ to see the changes. Benchmarks is based on merging with master (4cfffbe) |
tests/pos/ghost-pathdep-1.scala
Outdated
| fun3(new Bar) | ||
|
|
||
| def fun1[F >: Bar <: Foo](ghost f: F): f.X = null.asInstanceOf[f.X] | ||
| def fun2[F >: Bar <: Foo](ghost f: F)(ghost bar: f.B): f.B = null.asInstanceOf[f.B] |
There was a problem hiding this comment.
Make them neg tests. It is always good to make sure we do not have a regression.
| @@ -600,7 +600,7 @@ object SymDenotations { | |||
|
|
|||
| /** Is this a denotation of a stable term (or an arbitrary type)? */ | |||
| final def isStable(implicit ctx: Context) = | |||
| isType || is(Stable) || !(is(UnstableValue) || info.isInstanceOf[ExprType]) | |||
| isType || !is(Ghost) && (is(Stable) || !(is(UnstableValue) || info.isInstanceOf[ExprType])) | |||
There was a problem hiding this comment.
We should avoid marking the symbols as stable if they are ghost. We could assert that a symbol must at most one of those flags.
There was a problem hiding this comment.
Because in some places we might ask if sym.is(Stable) which would say true for a symbol with Stable and Ghost flags.
There was a problem hiding this comment.
Actually don't do this change
|
@nicolasstucki Good for you? |
Closes #4060.