Fix #4395: Handle ## when it is an Ident #4474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanrenucci
reviewed
May 7, 2018
| override def transformIdent(tree: tpd.Ident)(implicit ctx: Context): Tree = { | ||
| if (tree.symbol.isTerm && (defn.Any_## eq tree.symbol.asTerm)) { | ||
| val cls = ctx.owner.ownersIterator.find(_.isClass).get.asClass | ||
| val rewrite = poundPoundValue(This(cls)) |
There was a problem hiding this comment.
I think what you want is tpd.desugarIdentPrefix
| @@ -54,6 +38,16 @@ class InterceptedMethods extends MiniPhase { | |||
| else tree | |||
| } | |||
|
|
|||
| override def transformIdent(tree: tpd.Ident)(implicit ctx: Context): Tree = { | |||
There was a problem hiding this comment.
Can you factor out the common code between transformIdent and transformSelect
There was a problem hiding this comment.
poundPoundValue already factors it out. The rest is just slightly different.
There was a problem hiding this comment.
What about something like:
private def transformRefTree(tree: RefTree)(implicit ctx: Context): Tree =
if (tree.symbol.isTerm && (defn.Any_## eq tree.symbol)) {
val qual = tree match
case id: Ident => tpd.desugarIdentPrefix(id)
case sel: Select => sel.qual
}
val rewrite = poundPoundValue(qual)
ctx.log(s"$phaseName rewrote $tree to $rewrite")
rewrite
}
else tree
override def transformIdent(tree: tpd.Ident)(implicit ctx: Context) =
transformRefTree(tree)
override def transformSelect(tree: tpd.Select)(implicit ctx: Context): Tree =
transformRefTree(tree)There was a problem hiding this comment.
Though it added a line of code
allanrenucci
approved these changes
May 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.