Add standard definitions on Tasty reflect #4895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-tasty-reflect-std-definitions
branch
4 times, most recently
from
dd34566 to
6d96851
Compare
nicolasstucki
changed the title
Based on scala.reflect
nicolasstucki
force-pushed
the
add-tasty-reflect-std-definitions
branch
from
6d96851 to
ad63d93
Compare
liufengyun
approved these changes
Aug 7, 2018
| import dotty.tools.dotc.core.Types._ | ||
|
|
||
| object FromSymbol { | ||
| trait FromSymbol { tasty: TastyImpl => |
There was a problem hiding this comment.
It seems tasty: TastyImpl is not used in the implementation? What's the motivation to change from object to trait?
There was a problem hiding this comment.
This change is not needed, I will revert it
| */ | ||
| trait StandardTypes { | ||
| /** The type of primitive type `Unit`. */ | ||
| def UnitTpe: Type |
There was a problem hiding this comment.
For readability, I prefer UnitType instead of UnitTpe. The same for the other names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on scala.reflect