Skip to content

Fix #5008: forbid enums extending enums #5028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions compiler/src/dotty/tools/dotc/typer/Typer.scala
Original file line number Diff line number Diff line change
Expand Up @@ -1575,6 +1575,15 @@ class Typer extends Namer
if (!cls.is(AbstractOrTrait) && !ctx.isAfterTyper)
checkRealizableBounds(cls, cdef.namePos)
if (cls.is(Case) && cls.derivesFrom(defn.EnumClass)) checkEnum(cdef, cls)
if (seenParents.contains(defn.EnumClass)) {
// Since enums are classes and Namer checks that classes don't extend multiple classes, we only check the class
// parent.
val firstParent = parents1.head.tpe.dealias.typeSymbol
if (firstParent.derivesFrom(defn.EnumClass))
//Tricky to phrase; language taken from "case-to-case inheritance is prohibited".
ctx.error(s"Enum ${cls.name} has enum ancestor ${firstParent.name}, but enum-to-enum inheritance is prohibited", cdef.pos)
}

val cdef1 = assignType(cpy.TypeDef(cdef)(name, impl1), cls)
checkVariance(cdef1)
if (ctx.phase.isTyper && cdef1.tpe.derivesFrom(defn.DynamicClass) && !ctx.dynamicsEnabled) {
Expand Down
5 changes: 5 additions & 0 deletions tests/neg/i5008.scala
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
enum Foo { case A }
enum Bar { case A }
enum Baz extends Foo { case Z } // error

enum Quux extends Foo with Bar { case Z } // error
2 changes: 0 additions & 2 deletions tests/pending/neg/i5008

This file was deleted.