Skip to content

Fix #5155: Use platform dependent URI creation #5156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2018
Merged

Fix #5155: Use platform dependent URI creation #5156

merged 1 commit into from
Sep 25, 2018

Conversation

melekhove
Copy link
Contributor

Fixes #5155

dottybot
dottybot reviewed Sep 25, 2018
View reviewed changes
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Have an awesome day! ☀️

allanrenucci
allanrenucci approved these changes Sep 25, 2018
View reviewed changes
Copy link
Contributor

@allanrenucci allanrenucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@allanrenucci allanrenucci merged commit 561c06a into scala:master Sep 25, 2018
@melekhove melekhove deleted the issue/5155 branch September 25, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottybot dottybot dottybot left review comments

+1 more reviewer

@allanrenucci allanrenucci allanrenucci approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@melekhove @allanrenucci @dottybot