Fix #5397: Visit local method in Tailrec #5431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Nov 12, 2018
allanrenucci
force-pushed
the
fix-5397
branch
3 times, most recently
from
c48f7fa to
56ab2f2
Compare
sjrd
approved these changes
Nov 14, 2018
If a method is annotated with @tailrec we now report invalid recursive call within local method. This means we now visit by-name arguments, closures and lifted `try`s
allanrenucci
force-pushed
the
fix-5397
branch
from
56ab2f2 to
4d9d4fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a method is annotated with @tailrec we now report invalid recursive
call within local method. This means we now visit by-name arguments,
closures and lifted
trys