Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #5346: Refine implicit resolution spec #5633

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fix #5346: Refine implicit resolution spec #5633

merged 1 commit into from
Dec 17, 2018

Conversation

odersky
Copy link
Contributor

@odersky odersky commented Dec 17, 2018

Add discussion of by-name parameters.

@odersky
Fix scala#5346: Refine implicit resolution spec
1206dad 
Add discussion of by-name parameters.
smarter
smarter approved these changes Dec 17, 2018
View reviewed changes
Copy link
Member

@smarter smarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we considered keeping the Scala 2 behavior under -language:Scala2 ?

@odersky
Copy link
Contributor Author

odersky commented Dec 17, 2018

@smarter

Have we considered keeping the Scala 2 behavior under -language:Scala2 ?

I think that would be too hard to do for too little gain.

@odersky odersky closed this Dec 17, 2018
@odersky odersky reopened this Dec 17, 2018
@smarter
Copy link
Member

smarter commented Dec 17, 2018

Then we just need to convince @adriaanm to align with Dotty in 2.14 here :)

@odersky odersky merged commit df6232b into scala:master Dec 17, 2018
@allanrenucci allanrenucci deleted the fix-#5346 branch December 17, 2018 14:35
@adriaanm adriaanm mentioned this pull request Jan 14, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarter smarter smarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@odersky @smarter