-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Embryonic but functioning JSR223 support #5686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dottybot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello, and thank you for opening this PR! 🎉
All contributors have signed the CLA, thank you! ❤️
Have an awesome day! ☀️
dedb1ef to
62a4282
Compare
|
This doesn’t look very invasive but it needs tests, unless there’s an extremely good reason. |
326090f to
ace3584
Compare
|
@rjolly So, that looks cool! As a follow-up: to also test what you asked, I asked @smarter. You can do that by creating an SBT project that depends on the compiler, and test it using sbt-scripted. |
|
@rjolly But I'd be already happy to merge this, honestly, if you can't get to that quickly. Let me know. |
0de79e4 to
373f0e8
Compare
|
@Blaisorblade The problem was with the classloader used by the |
5aedbf3 to
0cfc260
Compare
48f70d4 to
2d14f14
Compare
smarter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, any more comments @allanrenucci ?
This is mainly to obtain feedback. Once on track, I will consider remaining features like compiled scripts, variable bindings, classpath issues and so on, to be on par with the 2.12 implementation.
How to run: