Realizability: fixes and cleanups of docs #5730
Merged
+75
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blaisorblade
commented
Jan 16, 2019
| @@ -50,7 +50,15 @@ object CheckRealizable { | |||
| private val LateInitialized = Lazy | Erased | |||
| } | |||
|
|
|||
| /** Compute realizability status */ | |||
| /** Compute realizability status. | |||
|
Relevant sections of the Scala spec: https://www.scala-lang.org/files/archive/spec/2.13/03-types.html#paths But Dotty does not strictly follow those definitions. A future PR should describe their relation. |
Blaisorblade
commented
Jan 17, 2019
| final def isStable(implicit ctx: Context): Boolean = { | ||
| /** Is this a denotation of a stable term (or an arbitrary type)? | ||
| * Terms are stable if they are idempotent (as in TreeInfo.Idempotent): that is, they always return the same value, | ||
| * if any. |
There was a problem hiding this comment.
The relation between stable and idempotent was a bit surprising to me and @odersky, but I think I just convinced him (in a quick chat) this makes sense. Counterexamples welcome!
OlivierBlanvillain
approved these changes
Jan 21, 2019
Blaisorblade
force-pushed
the
realizability-cleanup-doc
branch
from
c05e58b to
b0c8e68
Compare
|
@odersky This is the documentation/refactoring PR I mentioned... Merged since it got approved (and it's only comments and refactorings), tho we can revisit this if needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt at documenting realizability and stability. If this makes enough sense, I think one turn this into documentation.
There's also a behavior change, but I moved that in ##5726. I'll probably rebase this once that's merged.