Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add regression test for tasty reflect case study #5797

Merged
merged 45 commits into from
Jan 29, 2019
Merged

Add regression test for tasty reflect case study #5797

merged 45 commits into from
Jan 29, 2019

Conversation

biboudis
Copy link
Contributor

@biboudis biboudis commented Jan 25, 2019 •
edited
Loading

This PR pushes a toy interpreter for TASTy expressions. The main test file is on the tasty-interpreter/InterpretedMain.scala file where we support value declarations, if, while, arithmetic, method definitions, method calls (interpreted or via a reflective proxy if they are precompiled).

Also small additions to SymbolOps:

  • isDefinedInCurrentRun
  • signature in DefSymbolDeco
  • moduleClass in ValSymbolDeco
  • classSymbol in TypeDeco

biboudis and others added 30 commits January 25, 2019 17:01
@biboudis
Add basic structure
9ff84c6
@biboudis
Update tasty-interpreter.check
55dd7fc
@biboudis
LF endings
fe86dd6
@biboudis
Handle simple method calls
7e75c43
@biboudis
Update extractor
b65b1b0
@biboudis
Move interpreter
6c11c9d
@biboudis
Add JVM reflect
a5fd508
@biboudis
Add JVM reflect for static methods without params
5fe6446
@biboudis
Decouple static val from static meth reflection
13ff866
@biboudis
wip
6ffa3b0
@biboudis
Handle static methods with parameter
663adba
@biboudis
Handles multiple args
32c0805
@biboudis
Adding reflective proxies
9cf5c4d
@biboudis
Cleanup
8b076ba
@nicolasstucki @biboudis
Move classes into packages
6d96ba2
@nicolasstucki @biboudis
Move Ref and subclasses to to their own files
642c29f
@nicolasstucki @biboudis
Remove unnecessary ctx
c05a971
@nicolasstucki @biboudis
Split tree interreter from jvm interpreter
a5ae022
@nicolasstucki @biboudis
Move logic out of eval
2fdd5dc
@nicolasstucki @biboudis
Implement isInstanceOf and asInstanceOf
5d7f940
@nicolasstucki @biboudis
Abstract over interpreted object representation
7e3b36e
@nicolasstucki @biboudis
Pass evaluated prefix
4b1c8cd
@nicolasstucki @biboudis
Refactor Ref (now LocalValue)
e7e39f1
@nicolasstucki @biboudis
Remove deadcode
61de0fa
@nicolasstucki @biboudis
Abstract over ==
4c5b39d
@nicolasstucki @biboudis
Abstract over primitive numeric operations
f64013d
@nicolasstucki @biboudis
Implement primitive divition
5b30f9d
@nicolasstucki @biboudis
Add <= and =>
93ac8cd
@nicolasstucki @biboudis
Use custom output check as compileDir does use the checkfile
73584ac
@nicolasstucki @biboudis
Remove code added by mistake
74ffc6e
@nicolasstucki
Copy link
Contributor

@biboudis something failed after the rebase.

@biboudis biboudis force-pushed the create-interpreter branch 2 times, most recently from 521e9f2 to 85e9e6a Compare January 28, 2019 13:11
@biboudis
Copy link
Contributor Author

Rebased

nicolasstucki
nicolasstucki reviewed Jan 29, 2019
View reviewed changes
Copy link
Contributor

@nicolasstucki nicolasstucki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

library/src/scala/tasty/reflect/FlagSet.scala Outdated Show resolved Hide resolved
@ghost ghost added the review label Jan 29, 2019
@biboudis
Copy link
Contributor Author

@dotty-bot recheck cla

@nicolasstucki nicolasstucki merged commit ad94ab5 into scala:master Jan 29, 2019
@ghost ghost removed the review label Jan 29, 2019
@nicolasstucki nicolasstucki deleted the create-interpreter branch January 29, 2019 13:04
@Blaisorblade Blaisorblade mentioned this pull request Jan 29, 2019
Merged
Blaisorblade added a commit to dotty-staging/dotty that referenced this pull request Jan 29, 2019
@Blaisorblade
Fix build: Port scala#5797 to new syntax from scala#5458
f079dd3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolasstucki nicolasstucki nicolasstucki approved these changes

Assignees

@biboudis biboudis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@biboudis @nicolasstucki