Fix #6007: Get the classloader that loaded the application #6017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biboudis
changed the title
|
Added a scripted test to emulate #6007
|
biboudis
changed the title
biboudis
changed the title
nicolasstucki
force-pushed
the
fix-#6007
branch
from
88c0826 to
4c17df3
Compare
nicolasstucki
changed the title
nicolasstucki
force-pushed
the
fix-#6007
branch
2 times, most recently
from
fb73a43 to
c40ec10
Compare
nicolasstucki
requested review from
liufengyun
and removed request for
nicolasstucki
allanrenucci
reviewed
Apr 1, 2019
It is impossible ensure that the correct classloader is used.
Bail out on trying to figure out the class loader and force the user to provide it. As it was done in Scala 2.
ghost
removed
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that the classloader used to load the library is not the same as the one that loads the rest of the aplication. The toolbox requires the classloader that loaded the main of the application, the one that has all the classpath dependencies of the appliaction.