Skip to content

Follow up to #6002 #6067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2019
Merged

Follow up to #6002 #6067

merged 1 commit into from
Mar 10, 2019

Conversation

allanrenucci
Copy link
Contributor

  • Reject enums with no case instead of empty enums.
  • Remove special case in parser by using the tenmplate parser
    to enforce enums have bodies.

@allanrenucci
Follow up to scala#6002
9d6a9a2 
- Reject enums with no case instead of empty enums.
- Remove special case in parser by using the `tenmplate` parser
  to enforce enums have bodies.
@allanrenucci allanrenucci requested a review from liufengyun March 10, 2019 15:54
liufengyun
liufengyun approved these changes Mar 10, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@allanrenucci allanrenucci merged commit 851f371 into scala:master Mar 10, 2019
@allanrenucci allanrenucci deleted the followup-6002 branch March 10, 2019 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allanrenucci @liufengyun