Skip to content

Fix #5376, fix #5434: Unpickle quotes eagerly #6963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 3, 2019
Merged

Fix #5376, fix #5434: Unpickle quotes eagerly #6963

merged 3 commits into from
Aug 3, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented Jul 30, 2019 •
edited
Loading

No description provided.

@nicolasstucki nicolasstucki self-assigned this Jul 30, 2019
@nicolasstucki nicolasstucki force-pushed the fix-#5376 branch 3 times, most recently from 2e92d7a to a635fc1 Compare July 31, 2019 15:34
@nicolasstucki nicolasstucki requested a review from liufengyun July 31, 2019 15:35
@nicolasstucki nicolasstucki marked this pull request as ready for review July 31, 2019 17:31
liufengyun
liufengyun previously approved these changes Jul 31, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM

@nicolasstucki nicolasstucki dismissed liufengyun’s stale review August 1, 2019 07:20

I will move logic around

liufengyun
liufengyun approved these changes Aug 3, 2019
View reviewed changes
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice refactoring 👍

@nicolasstucki nicolasstucki merged commit 36707c7 into scala:master Aug 3, 2019
@nicolasstucki nicolasstucki deleted the fix-#5376 branch August 3, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liufengyun liufengyun liufengyun approved these changes

Assignees

@liufengyun liufengyun

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasstucki @liufengyun