Use given instead of implicit #7177
Conversation
nicolasstucki
force-pushed
the
use-given-in-quoted
branch
5 times, most recently
from
48b780b to
399d8fe
Compare
| @@ -42,8 +42,7 @@ | |||
| url = https://github.com/dotty-staging/scala-xml | |||
| [submodule "community-build/community-projects/shapeless"] | |||
| path = community-build/community-projects/shapeless | |||
| url = https://github.com/milessabin/shapeless | |||
| branch = shapeless-3 | |||
| url = https://github.com/dotty-staging/shapeless | |||
There was a problem hiding this comment.
@milessabin, to make some small changes to shapeless I forked it and used a new branch. I will upstream those changes once this PR is merged.
nicolasstucki
force-pushed
the
use-given-in-quoted
branch
from
399d8fe to
6ca4676
Compare
|
Maybe best to wait until #7151 is resolved before merging this ? |
|
I would say we should not wait. This PR modified only a few definitions using |
There was a problem hiding this comment.
Discussed with @nicolasstucki , it's good to merge this, so that we can see whether the syntax change plays well with real code or not.
|
I vote for holding off. If we change the syntax we will disallow the old given syntax, so we will have a major migration hassle on our hands. |
|
Ok, then I'll reopen this PR when #7151 is in. |
No description provided.